Ensure that pixel_crop produces correct size for lazy rasters #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #105 +/- ##
=========================================
+ Coverage 89.09% 89.1% +<.01%
=========================================
Files 30 30
Lines 4164 4167 +3
=========================================
+ Hits 3710 3713 +3
Misses 454 454
Continue to review full report at Codecov.
|
astrojuanlu
commented
Aug 6, 2018
| @@ -999,8 +999,8 @@ def pixel_crop(self, bounds, xsize=None, ysize=None, window=None): | |||
| else: | |||
| window = window or rasterio.windows.Window(bounds[0], | |||
| bounds[1], | |||
| bounds[2] - bounds[0] + 1, | |||
| bounds[3] - bounds[1] + 1) | |||
| bounds[2] - bounds[0], | |||
There was a problem hiding this comment.
@guydou proposed
max(bounds[2] - bounds[0], 1)
but it would be better to first discuss what are we trying to avoid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.