CMS Blog Posts, CMS Application Types, set up Unit Tests #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjarling
force-pushed
the
118-blog-post-cms
branch
from
573d946
to
18085cd
Compare
adamjarling
force-pushed
the
118-blog-post-cms
branch
2 times, most recently
from
98b137c
to
4886974
Compare
…g a Blog Post via Contentful CMS
adamjarling
force-pushed
the
118-blog-post-cms
branch
from
4886974
to
930af1b
Compare
mathewjordan
requested changes
Nov 21, 2023
| @@ -30,7 +30,6 @@ export default function UserProfilesPage({ config, content, frontmatter }) { | |||
|
|
|||
| fetchData(); | |||
| }, [contentful]); | |||
| console.log("userProfiles", userProfiles); | |||
pages/_app.js
Outdated
There was a problem hiding this comment.
The og: data looks good in the head, but pages seem to be missing a title tag.
What about hard feeding it as:
<Head>
<title>{ogData["og:title"]}</title>
{/* Add Open Graph <meta></meta> tags here */}
{Object.keys(ogData).map((key) => (
// @ts-ignore
<meta property={key} content={ogData[key]} key={key} />
))}
</Head>| </Main> | ||
| </Layout> | ||
| ); | ||
| } | ||
|
|
||
| export async function getStaticProps() { | ||
| const { previews } = getNewsPreviews(); | ||
| const subsetOfPreviews = previews.slice(0, 30); | ||
|
|
||
| const blogPosts = await getBlogPosts(); |
There was a problem hiding this comment.
Suggested change
| const blogPosts = await getBlogPosts(); | |
| const blogPosts = await getBlogPosts(); | |
| const openGraphData = { | |
| "og:title": "News and Events - Samvera", | |
| "og:description": | |
| "Learn about the latest News and Events in the Samvera Community.", | |
| }; |
pages/news-and-events/index.jsx
Outdated
|
|
||
| return { | ||
| props: { previews }, | ||
| props: { blogPosts, previews: subsetOfPreviews }, |
There was a problem hiding this comment.
Suggested change
| props: { blogPosts, previews: subsetOfPreviews }, | |
| props: { blogPosts, previews: subsetOfPreviews, openGraphData }, |
Since this is the coming as index.jsx page, perhaps we should hardset these openGraphData values as well? Otherwise it seems to fall back to homepage values.
|
Good call here @mathewjordan I'm updating OpenGraph data in other core pages as well. Thanks! |
This was
linked to
issues
Nov 21, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
@heathergreerklein So there is a LOT in this PR. Please don't merge it (I'll handle that after @mathewjordan puts some eyes on it for a sanity check). Also we should go over what content has now moved to Contentful. Maybe we can do a quick chat this week via Slack?
Essentially if you log into Contentful, you'll now see BlogPost entries, and this is where you should enter new Blog Posts (News and Event postings) from this point forward.
And now back to what this PR does:
.mdfiles in the new Blog Post UIHome page screen shot
New Application Types UI on homepage (replaces the slider)
Application Types New page
Update Community Banner on homepage
Updated News and Events page
Individual News and Event (Blog) page
To run tests (if you're a dev and comfortable with this), on the command line, run:
pnpm run testAnd notice here that Github Actions are now running tests on PRs to
mainbranch (this PR is first time):https://github.com/samvera/samvera.org/actions