Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migrate collection thumbnails rake #2273

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

kirkkwang
Copy link
Collaborator

We discovered on staging that we don't actually need this because the collection thumbnails are still presenter after migrating the collection to a collection resource.

Hyrax::IndexesThumbnailsDecorator#thumbnail_path will handle the fallback which is why it is working.

Ref:

We discovered on staging that we don't actually need this because the
collection thumbnails are still presenter after migrating the collection
to a collection resource.

Hyrax::IndexesThumbnailsDecorator#thumbnail_path will handle the
fallback which is why it is working.

Ref:
  - scientist-softserv/palni_palci_knapsack#110
@kirkkwang kirkkwang added the patch-ver for release notes label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Test Results

    3 files  ±0      3 suites  ±0   18m 17s ⏱️ +26s
2 024 tests  - 3  1 974 ✅  - 3  50 💤 ±0  0 ❌ ±0 
2 051 runs   - 3  1 999 ✅  - 3  52 💤 ±0  0 ❌ ±0 

Results for commit 658a157. ± Comparison against base commit d16e66d.

This pull request removes 45 and adds 42 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5f78f05c-7341-4438-b652-9e8ea61500c0
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 34e8ff4d-4a4a-4598-aa5f-9da0cf907c85
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read a0061912-a5c1-4767-b4d5-c88057b904f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 19e90276-32ca-4db7-8a07-8cc027a67794
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 850a39d8-e7cd-4fd5-997c-2ccca15d896b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 8740c17b-054c-4876-8a1a-3bce5079e89e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ab0b34f8-9473-434c-9bb6-abf659e0821f
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update efd0c5f3-d886-4796-8558-d1214f596a63
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 38034f89-8b9e-4bf1-9dc7-432862130916
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit f01fdf61-fe20-413d-8816-53989dba8a88
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b94436a6-67dc-4341-9342-352b51ad4f68
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 187a5cb9-8152-4aa6-8cd2-2a8c00a31b95
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 1c209e09-f4e6-4d52-b6dd-d45a5c79b8ec
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 096b7fc9-6226-4c24-816c-5d6af5c494e2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 1f0d2bf2-aa5c-4dd4-9ad1-41f0dba4003b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 98c563fc-7fad-40b4-9919-028cf3fe981c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 05ffce55-4010-4edc-adb9-2d462cccb03a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 088e5191-726a-46c9-a3ab-71e153a7fa75
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 49e593fe-d0ea-4919-9943-99a9e08a29fe
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit a62edebd-5e52-424a-9185-a4d28153e85d
…

@kirkkwang kirkkwang merged commit 8720a37 into main Aug 8, 2024
9 checks passed
@kirkkwang kirkkwang deleted the remove-collection-thumbnails branch August 8, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants