Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Feedback => tickets #2194

Open
9 tasks done
ShanaLMoore opened this issue Apr 23, 2024 · 2 comments
Open
9 tasks done

PR Feedback => tickets #2194

ShanaLMoore opened this issue Apr 23, 2024 · 2 comments

Comments

@ShanaLMoore
Copy link
Collaborator

ShanaLMoore commented Apr 23, 2024

ref:

image

I'll create a separate ticket for this to open for discussion. This was contributed back from pals to sort sub collections by title on default. What should the global default behavior be, if otherwise?

  • app/controllers/hyrax/dashboard/profiles_controller_decorator.rb
image

@orangewolf this comes from pals and it got implemented along with the use roles work. I'm going to leave it for now.

ref:

image

@orangewolf Jeremy left this comment:

    # @note We likely want to extract something like this to Bulkrax.
    #       However, we probably cannot assume that we have a field named
    #       `based_near` that is in fact the Location field.
    #
    #       On possibility is to have a Hash that has key of :name and value
    #       of a lambda; that Lambdawould receive the given :result and return
    #       the correct value.  As we can see in the implementation below, we
    #       need to consider the `Site.instance` which is a Hyku specific
    #       consideration.

so I think he would agree with you but didn't have the time to think about it and follow through. I can make a ticket for us to handle this later.

  • app/models/file_download_stat_decorator.rb
image

re: @orangewolf

Here is the commit from pals, and here is the original ticket.

also ref ticket

It uses Legato for file analystics reports

It looks like part of this work (app/models/hyrax/statistic_decorator.rb) already got contributed back to hyrax.

file set decorator exists because '# OVERRIDE Hyrax hyrax-v3.5.0 to require Hyrax::Download so the method below doesn't fail'. The only diff between this and the one in hyrax is calling Hyrax::Download

  • app/views/catalog/_index_header_list_default.html.erb
image

re: @orangewolf I think this is ok.

It was taken from pals which duplicates the same exact code in both conditionals; basically it should always display. So it looks like Jeremy dried that bit up and left the remaining conditional to handle collections. Logically I think it looks equivalent.

Moreover, I tested the search and here are my results. We'll have to look into why thumbnails don't render.

https://github.com/scientist-softserv/palni-palci/blob/main/app/views/catalog/_index_header_list_default.html.erb

  • app/views/hyrax/base/_related_items.html.erb
image

@orangewolf this is the entire commit. Looks to be intentional. The commit message says: " Add render of empty related items partial "

  • lib/tasks/sidekiq.rake
image
  • spec/controllers/hyrax/homepage_controller_spec.rb
image
  • spec/features/create_work_spec.rb
image
@ShanaLMoore
Copy link
Collaborator Author

ShanaLMoore commented Apr 24, 2024

OTHER NOTICED ISSUES

image

image

It should look like:
image

    # @note We likely want to extract something like this to Bulkrax.
    #       However, we probably cannot assume that we have a field named
    #       `based_near` that is in fact the Location field.
    #
    #       On possibility is to have a Hash that has key of :name and value
    #       of a lambda; that Lambdawould receive the given :result and return
    #       the correct value.  As we can see in the implementation below, we
    #       need to consider the `Site.instance` which is a Hyku specific
    #       consideration.

RELATED?:

2024-04-24T21:51:22.442Z pid=547 tid=b8n7 WARN: RSolr::Error::Http: RSolr::Error::Http - 400 Bad Request
Error: Unable to index docs with children: the schema must include definitions for both a uniqueKey field and the '_root_' field, using the exact same fieldType
image

generic_work_locations_test.csv

What should the default be?

image

@ShanaLMoore
Copy link
Collaborator Author

ShanaLMoore commented Apr 25, 2024

HYKU v6.0.0 is a show stopper until we fix:

@ShanaLMoore to create tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant