Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation fixes #13554

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Documentation fixes #13554

merged 2 commits into from
Oct 16, 2024

Conversation

ageorgou
Copy link
Contributor

changelog: none

The URLs contained an extra `clippy_lints`, which resulted in
broken links. Links are generated using each lint's `id_location`,
which already contains the full path inside the repository.
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Centri3 (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 15, 2024
@xFrednet xFrednet assigned xFrednet and unassigned Centri3 Oct 16, 2024
@xFrednet
Copy link
Member

Welcome to Clippy, and thank you for the update! :D

These changes look good to me, nice catch with the URL!


Roses are red,
Violets are blue,
this contains keys,
and correct URLs

@bors
Copy link
Collaborator

bors commented Oct 16, 2024

📌 Commit 4863625 has been approved by xFrednet

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Oct 16, 2024

⌛ Testing commit 4863625 with merge ccb30bf...

@bors
Copy link
Collaborator

bors commented Oct 16, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: xFrednet
Pushing ccb30bf to master...

@bors bors merged commit ccb30bf into rust-lang:master Oct 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants