Allow to go through clippy lints page without javascript #13539
Merged
+46
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Alexendoo
reviewed
Oct 12, 2024
util/gh-pages/script.js
Outdated
| }); | ||
| }; | ||
| onEachLazy(elem.querySelectorAll("pre > code.language-rust:not(.highlighted)"), call); | ||
| onEachLazy(elem.querySelectorAll("pre > code.language-no_run:not(.highlighted)"), call); |
There was a problem hiding this comment.
Oh I see. Gonna update then.
GuillaumeGomez
force-pushed
the
allow-no-js
branch
3 times, most recently
from
a0c56a5
to
147d2a4
Compare
|
Fixed the bug. I took an approach a little bit different by using the |
|
It should use |
GuillaumeGomez
force-pushed
the
allow-no-js
branch
from
147d2a4
to
d60d145
Compare
|
Changed the code to use |
Alexendoo
reviewed
Oct 18, 2024
util/gh-pages/style.css
Outdated
| content: "+"; | ||
| } | ||
| article > input[type="checkbox"]:checked + label .label-doc-folding::before { | ||
| content: "-"; |
GuillaumeGomez
force-pushed
the
allow-no-js
branch
from
d60d145
to
da19d47
Compare
|
Fixed the minus sign. |
Alexendoo
approved these changes
Oct 18, 2024
|
👍 @bors r+ |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13536.
This is the follow-up of #13269.
This PR makes it possible to expand/collapse lints (individually) without JS. To achieve this result, there are two ways:
detailsandsummarytags. Problem with this approach is that the web browser search may open thedetailstags automatically if content matching it is inside. From a previous discussion with @Alexendoo, it seems to not be a desired behaviour.labeland a checkbox where the checkbox is in fact hidden. Then it's just a matter of CSS.r? @Alexendoo
changelog: Allow to go through clippy lints page without JS