-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New lint map_all_any_identity
#13499
Open
samueltardieu
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
samueltardieu:map-all-any-identity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New lint map_all_any_identity
#13499
samueltardieu
wants to merge
2
commits into
rust-lang:master
from
samueltardieu:map-all-any-identity
+159
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Oct 4, 2024
samueltardieu
force-pushed
the
map-all-any-identity
branch
from
October 4, 2024 23:19
bd308dd
to
bfa2683
Compare
r? @xFrednet |
xFrednet
reviewed
Oct 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three tiny nits, which should be easy to fix. Then it'll be ready :D
I've created an FCP: https://rust-lang.zulipchat.com/#narrow/stream/257328-clippy/topic/FCP/near/476583638
xFrednet
added
S-waiting-on-author
Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
S-final-comment-period
Status: final comment period it will be merged unless new objections are raised (~1 week)
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
labels
Oct 13, 2024
samueltardieu
force-pushed
the
map-all-any-identity
branch
from
October 13, 2024 09:02
bfa2683
to
334d2f4
Compare
@rustbot ready |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
and removed
S-waiting-on-author
Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
labels
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-final-comment-period
Status: final comment period it will be merged unless new objections are raised (~1 week)
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lint has been inspired by code encountered in Clippy itself (see the first commit).
changelog: [
map_all_any_identity
]: new lint