Bump MSRV, update v_frame, criterion and image #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreezyLemon
force-pushed
the
update-deps
branch
from
9730238
to
4338b17
Compare
|
Just realized that v_frame < 0.3.8 still has the unsound code and v_frame=0.3.8 has an MSRV of 1.64. Bumped v_frame requirement and MSRV to match. |
FreezyLemon
force-pushed
the
update-deps
branch
from
4338b17
to
6978e1b
Compare
|
Looks like nalgebra needs an MSRV that's even higher than 1.64. I'll hold it back for now, looking at #24 it's possible to remove it completely, so I don't want to bump MSRV for it atm. |
FreezyLemon
changed the title
|
Makes sense for now. Thanks! |
shssoichiro
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The criterion default features are kinda useless..
rayonmakes the analysis after each bench faster, but even without it takes <1 sec on my laptop in energy-saving mode, andcargo_bench_supportdoes nothing at all, AFAICT.imagedefault features is again rayon (not used in benches, so speed doesn't matter much) and a lot of image formats. We only need png at the moment.