testthat/integration tests for 5 apps #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
Jan 21, 2020
| # TODO Determine the ideal way for module-reliant test code to load an app | ||
| with_dir(shiny:::findApp(), { | ||
| local({ | ||
| source("app.R") |
There was a problem hiding this comment.
Is this still needed given you are passing in env?
There was a problem hiding this comment.
You know, I think it actually is, because of this bug that I just filed: rstudio/shiny#2746
There was a problem hiding this comment.
Thanks for pointing that out though, I had forgotten why it was necessary.
This reverts commit b584fc3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
testthat-based unit/integration tests to 5 applications that would be exercised by the testthat action in rstudio/shinycoreci#8The most important lesson I learned was probably that in order for modules to be available in the test environment, it's important to provide the
envargument totestthat::test_file(). Otherwise,testthatloads test files in a clean environment without the definitions added to the environment byshiny::runTests().It also occurred to me to add a first-class way to "click" an actionButton(); I created rstudio/shiny#2745 to track this.
I ran across what I think is a bug in
shiny::runTests(): rstudio/shiny#2746Overall, I had some difficulty adding what I would consider to be "helpful" tests.