Add types-pyyaml as test dependency #781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
Signed-off-by: Michael Carlstrom <[email protected]>
InvincibleRMC
requested review from
clalancette,
cottsay and
nuclearsandwich
as code owners
fujitatomoya
reviewed
Jun 7, 2024
There was a problem hiding this comment.
@clalancette i am not 100% sure about this, but this needs to be in the CI before ros2/launch#781?
CC: @InvincibleRMC
clalancette
requested changes
Jun 11, 2024
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
clalancette
requested changes
Jun 11, 2024
Co-authored-by: Chris Lalancette <[email protected]> Signed-off-by: Michael Carlstrom <[email protected]>
|
@clalancette Any update on this? Anything else you want from me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently ros2/launch#781 is failing because it cannot find
types-pyyamlthis dependency was added to rosdep here ros/rosdistro#40651. I could be mistaken but, I believe the proper course of action is maunally adding the dep here.