Pin all versions of python dependencies. #759
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial CI:
|
|
Note that this needs ros-infrastructure/ros2-cookbooks#66 as well. |
|
Here's additional CI:
|
This allows us to be in control of our destiny,
and not have random python upstream package updates
destroy the entire buildfarm.
We accomplish this through 3 different mechanisms,
depending on the platform:
1. Ubuntu - we install everything from debian packages,
and nothing from pip. Because Ubuntu promises
to not to breaking changes within a distribution,
this guarantees we won't break. This also
serves as our canonical version of what should work.
2. RHEL - For RHEL-9, we install everything from RPM packages,
and nothing from pip. For RHEL-8, we install most
everything from RPM packages, with the exception of
mypy, pytest, and pytest-rerunfailures. Since RHEL/EPEL
typically doesn't update major versions within a release,
we typically won't break.
3. Windows - We install all python packages via pip, and we constrain
the versions we install to those in Ubuntu. This means
that we'll always match what works on Ubuntu and we should
always work.
Signed-off-by: Chris Lalancette <[email protected]>
clalancette
force-pushed
the
clalancette/windows-pip-install
branch
from
2120d5d
to
496ae0e
Compare
|
Re-running CI on windows with the latest changes as sanity check: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to be in control of our destiny,
and not have random python upstream package updates destroy the entire buildfarm.
We accomplish this through 3 different mechanisms, depending on the platform:
Still a draft, as I need to run CI here and see what happens.