Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destructor of GazeboRosVideo #547

Conversation

davetcoleman
Copy link
Collaborator

Fixes #354 with the destructor warning:

terminate called after throwing an instance of 'boost::exception_detail::clone_impl<boost::exception_detail::error_info_injector<boost::lock_error> >'
terminate called recursively
  what():  boost: mutex lock failed in pthread_mutex_lock: Invalid argument
Aborted (core dumped)

This fix was copied from the GazeboRosForce plugin.

I also cleaned up the file while I was at it.

This PR is sponsored by Vicarious

@IanTheEngineer
Copy link
Contributor

Well done, Dave! I not tested your patch yet, but I'd bet that you've just fixed the core-dump issue that I reported ages ago: #354

@IanTheEngineer
Copy link
Contributor

Oops! I see that you've already linked the two tickets :)

@j-rivero
Copy link
Contributor

@osrf-jenkins run test please

@davetcoleman
Copy link
Collaborator Author

For some reason the tests seem stuck

@j-rivero
Copy link
Contributor

run test please

@davetcoleman
Copy link
Collaborator Author

one test passed, the other still seems stuck...

@j-rivero
Copy link
Contributor

one test passed, the other still seems stuck...

Yep, some problems with the integration into the testing farm. I think that we are good to go. Feel free to resolve the conflict and merge

@davetcoleman
Copy link
Collaborator Author

Conflicts fixed, all checks have passed, merging

@davetcoleman davetcoleman merged commit a89c2ad into ros-simulation:kinetic-devel Mar 3, 2017
@davetcoleman davetcoleman deleted the kinetic-video-desctructor branch March 3, 2017 04:42
cohen39 pushed a commit to cohen39/gazebo_ros_pkgs that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coredump on exit with Pure Virtual Call in GazeboRosVideo
3 participants