Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include introduction only in new GitHub reviews #27

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Oct 8, 2024

We're expanding the introduction text in the PR body to include more information, and it isn't helpful to include that information in follow-up reviews. If there are any reviews on a PR from 'github-actions[bot]' already, assume it was us.

@kscottz FYI

We're expanding the introduction text in the PR body to include more
information, and it isn't helpful to include that information in
follow-up reviews. If there are any reviews on a PR from
'github-actions[bot]' already, assume it was us.
@cottsay cottsay added the enhancement New feature or request label Oct 8, 2024
@cottsay cottsay self-assigned this Oct 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (8b70b18) to head (ce41509).

Files with missing lines Patch % Lines
rosdistro_reviewer/submitter/github.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
- Coverage   88.04%   87.66%   -0.39%     
==========================================
  Files          13       13              
  Lines         686      689       +3     
  Branches      178      180       +2     
==========================================
  Hits          604      604              
- Misses         61       64       +3     
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@christophebedard christophebedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cottsay cottsay merged commit cd74be7 into main Oct 8, 2024
18 checks passed
@cottsay cottsay deleted the cottsay/skip-intro-block branch October 8, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants