Replace broken round_up with u32::next_multiple_of
#125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output of `round_up` was `val + factor` instead of `val` when `val` was an exact multiple of factor. Use the standard library method instead which handles this case correctly. This change resulted in a small change to one of the E2E test outputs.
robertknight
force-pushed
the
fix-round-up
branch
from
c064e17
to
f649068
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of
round_upwasval + factorinstead ofvalwhenvalwas an exact multiple of factor. Use the standard library method instead which handles this case correctly. This change resulted in a small change to one of the E2E test outputs.