-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to opt-env-conf for Options and Config loading #282
Draft
pbrisbin
wants to merge
38
commits into
main
Choose a base branch
from
pb/option-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop validating for extra keys. This is a small hit to ergonomics in error cases, so we can continue to simplify things in general through off-the-shelf libraries like `opt-env-conf`.
Things that are *primarily* on `Config` are now under `Config.`. Just like things that were *primarily* on `Options` were under `Options.`. Obviously most things are both options and config. And both top-levels re-export the sub-modules. Re-export the `Config.Parse` module through `Config`. That way, when we fully replace it there's no need to change any `import`s. Together, this makes most code look correct already, even if we're still working through the `Config -> Config'` conversion.
pbrisbin
changed the title
pb/option values
Migrate to opt-env-conf for Options and Config loading
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely replaces our options, env, and configuration handling with the off-the-shelf library that does the same. The big benefit is that now everything (well, as much as makes sense) that is an "option" or "config" is handled uniformly from CLI options -> ENV values -> config file(s) -> defaults.
For example, there is now an
--exclude
option (used to only beexclude
in config) and there is now acli.fail_on_differences
config (used to be only a--fail-on-differences
switch).The new, complete
--help
:Along the way, we dropped about 1,000 lines of our code doing a poor job of some of this.
See above for all the new options, below is a list of only backwards incompatible change:
Configuration changes:
ENV changes:
UNRESTRICTED=x|<empty>
is nowRESTYLERS_RESTRICTED=true|false
RESTYLER_X
are nowRESTYLERS_X
NO_X=x|<empty>
is nowX=true|false
TERM
,NO_COLOR
,LOG_*
still work, but are not documentedCLI changes: