WIP: Plugin RFC #1028
Draft
WIP: Plugin RFC #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdonnay
force-pushed
the
hack/jsonschema
branch
from
6710e6b
to
6c73216
Compare
hdonnay
force-pushed
the
hack/jsonschema
branch
2 times, most recently
from
caef185
to
6166bcb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
- Coverage 55.76% 53.49% -2.27%
==========================================
Files 265 281 +16
Lines 16562 17559 +997
==========================================
+ Hits 9236 9394 +158
- Misses 6365 7190 +825
- Partials 961 975 +14 ☔ View full report in Codecov by Sentry. |
hdonnay
force-pushed
the
hack/jsonschema
branch
3 times, most recently
from
2f9259e
to
9c844bd
Compare
hdonnay
force-pushed
the
hack/jsonschema
branch
from
abe5ff0
to
b329453
Compare
hdonnay
force-pushed
the
hack/jsonschema
branch
from
b329453
to
37e8451
Compare
hdonnay
force-pushed
the
hack/jsonschema
branch
from
37e8451
to
f8cd7ff
Compare
hdonnay
force-pushed
the
hack/jsonschema
branch
from
f8cd7ff
to
bd7b78a
Compare
This sets up some support infrastructure to unify naming across claircore. The goal is to be able to pass around names as strings instead of interface objects. Signed-off-by: Hank Donnay <[email protected]>
This change adds a generic registry mechanism that is typesafe for users and enforces consistent naming. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
This adds a package to implement the user side of the global registry with a uniform creation and pooling workflow. Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
hdonnay
force-pushed
the
hack/jsonschema
branch
from
bd7b78a
to
e6c8fd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the code I wrote in parallel with writing #1032.
This branch has the net-new code added, with the caveat that the URN package needs an expanded test suite and a pass for correctness.