Java 21 #434
Open
Java 21 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
edeandrea
force-pushed
the
java-21-only
branch
4 times, most recently
from
fc77096
to
4702a91
Compare
edeandrea
force-pushed
the
main
branch
7 times, most recently
from
2207b61
to
e55a5b9
Compare
edeandrea
force-pushed
the
java-21-only
branch
2 times, most recently
from
55d96f3
to
58d07f0
Compare
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]> # Conflicts: # .github/workflows/build-push-container-images.yml # .github/workflows/simple-build-test.yml # event-statistics/pom.xml # grpc-locations/pom.xml # rest-fights/pom.xml # rest-heroes/pom.xml # rest-narration/README.md # rest-narration/pom.xml # rest-villains/pom.xml # scripts/generate-k8s-resources.sh # ui-super-heroes/pom.xml # Conflicts: # event-statistics/src/main/docker/Dockerfile.jvm # event-statistics/src/main/docker/Dockerfile.legacy-jar # event-statistics/src/main/resources/application.properties # grpc-locations/src/main/docker/Dockerfile.jvm # grpc-locations/src/main/docker/Dockerfile.legacy-jar # grpc-locations/src/main/resources/application.yml # rest-fights/src/main/docker/Dockerfile.jvm # rest-fights/src/main/docker/Dockerfile.legacy-jar # rest-fights/src/main/resources/application.properties # rest-heroes/src/main/docker/Dockerfile.jvm # rest-heroes/src/main/docker/Dockerfile.legacy-jar # rest-heroes/src/main/resources/application.yml # rest-narration/src/main/docker/Dockerfile.jvm # rest-narration/src/main/docker/Dockerfile.legacy-jar # rest-narration/src/main/resources/application.properties # rest-villains/src/main/docker/Dockerfile.jvm # rest-villains/src/main/docker/Dockerfile.legacy-jar # rest-villains/src/main/resources/application.properties # ui-super-heroes/src/main/docker/Dockerfile.jvm # ui-super-heroes/src/main/docker/Dockerfile.legacy-jar # ui-super-heroes/src/main/resources/application.properties
Signed-off-by: Eric Deandrea <[email protected]> # Conflicts: # .github/workflows/simple-build-test.yml # Conflicts: # .github/workflows/simple-build-test.yml
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
Signed-off-by: Eric Deandrea <[email protected]>
edeandrea
force-pushed
the
java-21-only
branch
from
9be382b
to
d40c16c
Compare
Signed-off-by: Eric Deandrea <[email protected]>
|
Looks like this PR is ready to go? What's missing? |
|
We were holding off on making the switch to java 21 as a baseline. We did this PR shortly after java 21 came out, so it was thought it may be better to wait a bit. That being said, I'm totally open to revisiting it. This PR would need some updates since |
|
@gastaldi I'm thinking that I will revisit this after RHBQ 3.15 ships. That way we have an rhbq-3.15 LTS branch with a Java 17 baseline and future versions can baseline on Java 21. @cescoffier / @geoand what do you think? |
|
No strong opinions either way |
cescoffier
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to Java 21 baseline
Fixes #376