Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project metadata and Docker builds #1435

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

mochaaP
Copy link

@mochaaP mochaaP commented Jan 9, 2024

Checklist

Which kind of PR do you create?

  • This PR only contains minor fixes.
  • This PR contains major feature updates.
  • This PR introduces a new function/API for Qiling Framework.

Coding convention?

  • The new code conforms to Qiling Framework naming convention.
  • The imports are arranged properly.
  • Essential comments are added.
  • The reference of the new code is pointed out.

Extra tests?

  • No extra tests are needed for this PR.
  • I have added enough tests for this PR.
  • Tests will be added after some discussion and review.

Changelog?

  • This PR doesn't need to update Changelog.
  • Changelog will be updated after some proper review.
  • Changelog has been updated in my PR.

Target branch?

  • The target branch is dev branch.

One last thing


@mochaaP
Copy link
Author

mochaaP commented Jan 10, 2024

/rr @elicn @xwings

Copy link
Member

@elicn elicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why removing the if __name__ == '__main__' statements?
It is not a Python 2 compliance; see Python 3 documentation here

@mochaaP
Copy link
Author

mochaaP commented Jan 10, 2024

It's not removed, it's wrapped into a run function so we can use it in the script entrypoint later.

@mochaaP mochaaP requested a review from elicn January 10, 2024 12:26
@elicn
Copy link
Member

elicn commented Jan 10, 2024

Oh, I see.. I must have missed that.

@elicn
Copy link
Member

elicn commented Jan 12, 2024

@mochaaP, what's with that .gitignore? It is full of redundant auto-generated stuff. Can you reduce it to the absolute necessary?

@mochaaP
Copy link
Author

mochaaP commented Jan 12, 2024

I don't think that's a particularly big issue?

@mochaaP
Copy link
Author

mochaaP commented Jan 12, 2024

The gitignore is just https://github.com/github/gitignore/blob/main/Python.gitignore with a few extra additions (poetry local config, ruff cache and pyright config).

@elicn
Copy link
Member

elicn commented Jan 13, 2024

We strive to keep the code clean as much as possible.
Please remove all redundant auto-generated additions.

@mochaaP
Copy link
Author

mochaaP commented Jan 13, 2024

Reduced to minimum while keeping the required for Poetry.

@mochaaP
Copy link
Author

mochaaP commented Jan 21, 2024

@xwings Ready for merge :)

Copy link
Member

@elicn elicn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore is still full of auto-generated stuff, but whatever.

@mochaaP
Copy link
Author

mochaaP commented Feb 9, 2024

Rebase & more cleanups.

@elicn elicn merged commit 7e7655e into qilingframework:dev Feb 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants