-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix project metadata and Docker builds #1435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why removing the if __name__ == '__main__'
statements?
It is not a Python 2 compliance; see Python 3 documentation here
It's not removed, it's wrapped into a |
Oh, I see.. I must have missed that. |
@mochaaP, what's with that |
I don't think that's a particularly big issue? |
The gitignore is just https://github.com/github/gitignore/blob/main/Python.gitignore with a few extra additions (poetry local config, ruff cache and pyright config). |
We strive to keep the code clean as much as possible. |
Reduced to minimum while keeping the required for Poetry. |
@xwings Ready for merge :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.gitignore
is still full of auto-generated stuff, but whatever.
Rebase & more cleanups. |
Checklist
Which kind of PR do you create?
Coding convention?
Extra tests?
Changelog?
Target branch?
One last thing