Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create instruments work type and pathway #1595
base: main
Are you sure you want to change the base?
Create instruments work type and pathway #1595
Changes from all commits
3753ebe
33c6ff3
e61e7fd
4a9c08e
0e140bb
0b722a4
ff82347
78a9e8a
6451f0d
6bf76a3
34a8421
86c6e6e
d582288
89efceb
70a1606
f8acb4f
1baddb6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't notice this before. We should run these dates through the date validation that
published_date
runs through below:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the EdtfDate module
#valid?
required the date to be a valid and present to return true so an empty available and/or decommission date would throw an error. This feels redundant becausepresence: true
onpublished_date
already handles this. I modified it so the module just validates format, allowing for blank values, and letpresence: true
handle that validation as needed.