-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/version match monitoring #100
base: master
Are you sure you want to change the base?
Feature/version match monitoring #100
Conversation
Thanks! I thought that we wanted to make an action that creates an issue. If it just sends a failed notification and will do it daily, then it will require us to manually clean up the notification in the email, create an issue, stop the action, and restart it when we finish the work. It seems like it would create a bunch of extra effort, don't you think? |
We can do it weekly then? An email every week might be a good reminder. |
Personally, I'd prefer an issue in the repo. Because the amount of notifications, I ignore GitHub emails and use the notifications in the UI to see what requires my attention. Also, having an issue gives an opportunity for others to contribute rather than me having to create an issue first. |
I'd definitely prefer this too. Unfortunately, there seems no built in functionality for that in Github. However, we could use some open source one, like this: https://github.com/marketplace/actions/create-an-issue. We will need to feed it some GitHub token, I hope you are alright with that @waldekmastykarz |
We can absolutely create a secret that allows us to create an issue from an action. To recap, the action should:
|
An action that automatically fails when the version of spfx in npm is higher than the one pushed to the docker Hub. I tested it in another organization with actions enabled and it worked just fine, alerting on my email when the failure (mismatch) is detected. Related to #96