-
Notifications
You must be signed in to change notification settings - Fork 426
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add test to verify that ConsumeMetrics and ConsumeTraces clear respon…
…se members (#1975) Summary: Add test to verify that ConsumeMetrics and ConsumeTraces clear response members This adds test coverage for the bug fix in #1910. This is a follow up to the conversation [here](#1910 (comment)) Relevant Issues: N/A Type of change: /kind bug Test Plan: Verified that unit test fails if #1910 is reverted ``` $ git show HEAD commit 4ab4a9c (HEAD -> ddelnano/add-tests-for-otel-sink-bug, ddelnano/ddelnano/add-tests-for-otel-sink-bug) Author: Dom Del Nano <[email protected]> Date: Fri Jul 26 12:17:00 2024 +0000 Revert "Clear trace response instead of metric response in `OTelExportSinkNode::ConsumeSpans` (#1910)" This reverts commit 970a54a. $ bazel test src/carnot/exec:otel_export_sink_node_test --test_output=all [ ... ] [ RUN ] OTelExportSinkNodeTest.consume_spans_clears_span_responses src/carnot/exec/otel_export_sink_node_test.cc:1748: Failure Value of: response->partial_success().rejected_spans() == 0 Actual: false Expected: true ``` --------- Signed-off-by: Dom Del Nano <[email protected]>
- Loading branch information
Showing
1 changed file
with
105 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters