Convert LuCI JS code to ES6 standard #6597
Draft
+2,027
−2,090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subsequent commits will modernize LuCI JavaScript code to use ES6 features, so drop the Promise polyfill as we're dropping support for non-ES6 browsers. Signed-off-by: Jo-Philipp Wich <[email protected]>
Convert existing JavaScript code in LuCI base to utilize ES6 standard features such as spread arguments, arrow functions, object method declarations etc. This makes the code somewhat easier to follow and slightly smaller. Signed-off-by: Jo-Philipp Wich <[email protected]>
|
With this PR, is it your opinion that we can start implementing ES6 for future JS code? |
systemcrash
added
WIP
stokito
approved these changes
Dec 6, 2023
|
The luci already have many places where the ES6 syntax is used. I can convert to ES6 other apps. |
|
I dislike semicolon omission and space indentation, so personally I am opposed to standard style. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains commits dropping polyfills not needed anymore on modern browsers and refactoring code to utilize ES6 syntax elements and features.