Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-15347: Update version go-http-metrics/gin #933

Open
wants to merge 1 commit into
base: release-4.14
Choose a base branch
from

Conversation

jkaurredhat
Copy link

go-http-metrics should be updated as this is pulling in the version of gin-gonic

In release-4.14
$ go mod graph | grep "gin-gonic/gin"
github.com/slok/[email protected] github.com/gin-gonic/[email protected]
github.com/slok/[email protected] github.com/gin-gonic/[email protected]
github.com/gin-gonic/[email protected] github.com/gin-contrib/[email protected]
github.com/gin-gonic/[email protected] github.com/go-playground/validator/[email protected]
github.com/gin-gonic/[email protected] github.com/golang/[email protected]
github.com/gin-gonic/[email protected] github.com/json-iterator/[email protected]
github.com/gin-gonic/[email protected] github.com/mattn/[email protected]
github.com/gin-gonic/[email protected] github.com/stretchr/[email protected]
github.com/gin-gonic/[email protected] github.com/ugorji/go/[email protected]
github.com/gin-gonic/[email protected] gopkg.in/[email protected]

$ grep go-http-metrics go.mod
github.com/slok/go-http-metrics v0.10.0 // indirect
In master branch the version with the fix is already being used.

$ grep go-http-metrics go.mod
github.com/slok/go-http-metrics v0.11.0 // indirect

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 15, 2024
@openshift-ci-robot
Copy link

@jkaurredhat: This pull request references Jira Issue OCPBUGS-15347, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-15347 to depend on a bug targeting a version in 4.15.0, 4.15.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

go-http-metrics should be updated as this is pulling in the version of gin-gonic

In release-4.14
$ go mod graph | grep "gin-gonic/gin"
github.com/slok/[email protected] github.com/gin-gonic/[email protected]
github.com/slok/[email protected] github.com/gin-gonic/[email protected]
github.com/gin-gonic/[email protected] github.com/gin-contrib/[email protected]
github.com/gin-gonic/[email protected] github.com/go-playground/validator/[email protected]
github.com/gin-gonic/[email protected] github.com/golang/[email protected]
github.com/gin-gonic/[email protected] github.com/json-iterator/[email protected]
github.com/gin-gonic/[email protected] github.com/mattn/[email protected]
github.com/gin-gonic/[email protected] github.com/stretchr/[email protected]
github.com/gin-gonic/[email protected] github.com/ugorji/go/[email protected]
github.com/gin-gonic/[email protected] gopkg.in/[email protected]

$ grep go-http-metrics go.mod
github.com/slok/go-http-metrics v0.10.0 // indirect
In master branch the version with the fix is already being used.

$ grep go-http-metrics go.mod
github.com/slok/go-http-metrics v0.11.0 // indirect

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 15, 2024
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2024
Copy link

openshift-ci bot commented Oct 15, 2024

Hi @jkaurredhat. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jkaurredhat
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@jkaurredhat: This pull request references Jira Issue OCPBUGS-15347, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-43369 to target a version in 4.15.0, 4.15.z, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mhanss
Copy link

mhanss commented Oct 15, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 15, 2024
@jkaurredhat
Copy link
Author

/jira refresh

@openshift-ci-robot
Copy link

@jkaurredhat: This pull request references Jira Issue OCPBUGS-15347, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 15, 2024
@bfournie
Copy link

/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv6

Copy link

openshift-ci bot commented Oct 15, 2024

@jkaurredhat: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jkaurredhat
Copy link
Author

/cherrypick release-4.13

@openshift-cherrypick-robot

@jkaurredhat: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2024
@rccrdpccl
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkaurredhat, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@jkaurredhat
Copy link
Author

/cherrypick release-4.13

@openshift-cherrypick-robot

@jkaurredhat: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherrypick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@bfournie
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 17, 2024
@openshift-ci-robot
Copy link

@bfournie: This pull request references Jira Issue OCPBUGS-15347, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-43369 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-43369 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @mhanss

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mhanss October 17, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants