feature: add discriminators #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davla I also have a generated C# client if you'd like to try it out. Still working on adding assistant streaming events tho. Should be in next release. Unfortunately the spec still has some troubles for auto generated schema clients. I have def ran into several edge cases. |
|
I also tried to generate(update) my client sdk via a YAML file, but sadly, the YAML file is not reliable. I have created PRs to fix it, but they have been waiting for months. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to generate a C# client via Kiota I had many warnings about missing discriminators. Given that it's part of the OpenAPI specification, I just added them to the spec where it was possible.
Furthermore, there were some duplicate YAML anchors definitions. I just removed them and referenced the first occurring one.