Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isolating log record processor #4062

Merged
merged 30 commits into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
3cc32ab
Allow independent log processing pipelines
pellared May 28, 2024
e405c6d
Clarify
pellared May 28, 2024
91f47dc
Refactor
pellared May 28, 2024
ee539c5
Rephrase
pellared May 28, 2024
05e6061
Add changelog
pellared May 28, 2024
721f185
Format
pellared May 28, 2024
a6ee1e5
Remove junk
pellared May 28, 2024
bab1025
Merge branch 'main' into fix-4010
pellared May 28, 2024
f3ced5c
Update sdk.md
pellared May 31, 2024
ddeddbe
Update sdk.md
pellared May 31, 2024
d086e7c
Update sdk.md
pellared May 31, 2024
3c96487
Update CHANGELOG.md
pellared May 31, 2024
10db84e
Update CHANGELOG.md
pellared May 31, 2024
3627816
Update sdk.md
pellared May 31, 2024
62777a4
Update sdk.md
pellared May 31, 2024
69ef0f7
Isolated processor instead of fan-out processor
pellared May 31, 2024
c5f943d
Merge branch 'main' into fix-4010
pellared Jun 3, 2024
7ee16e9
Update sdk.md
pellared Jun 3, 2024
89ff3d5
Update sdk.md
pellared Jun 3, 2024
b6a14e9
Merge branch 'main' into fix-4010
pellared Jun 4, 2024
948e81a
Update sdk.md
pellared Jun 4, 2024
eef1f09
Update CHANGELOG.md
pellared Jun 4, 2024
49b0b86
Rename to isolating processor
pellared Jun 4, 2024
dfd03e9
Format
pellared Jun 4, 2024
1b911cc
Update CHANGELOG.md
pellared Jun 4, 2024
320bf6e
Merge branch 'main' into fix-4010
pellared Jun 5, 2024
6bacc83
experimental to development
pellared Jun 5, 2024
d3954d5
Fix typo
pellared Jun 5, 2024
e9925dd
Merge branch 'main' into fix-4010
pellared Jun 18, 2024
e95c895
Merge branch 'main' into fix-4010
pellared Jun 27, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ release.

### Logs

- Add the in-development isolating log record processor.
([#4062](https://github.com/open-telemetry/opentelemetry-specification/pull/4062))

### Events

### Resource
Expand Down
24 changes: 23 additions & 1 deletion specification/logs/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
* [Built-in processors](#built-in-processors)
+ [Simple processor](#simple-processor)
+ [Batching processor](#batching-processor)
+ [Isolating processor](#isolating-processor)
- [LogRecordExporter](#logrecordexporter)
* [LogRecordExporter operations](#logrecordexporter-operations)
+ [Export](#export)
Expand Down Expand Up @@ -372,7 +373,13 @@ make the flush timeout configurable.
### Built-in processors

The standard OpenTelemetry SDK MUST implement both simple and batch processors,
as described below. Other common processing scenarios SHOULD be first considered
as described below.

**Status**: [Development](../document-status.md) -
The standard OpenTelemetry SDK SHOULD implement an isolating processor,
as described below.

Other common processing scenarios SHOULD be first considered
for implementation out-of-process
in [OpenTelemetry Collector](../overview.md#collector).

Expand Down Expand Up @@ -405,6 +412,21 @@ representations to the configured `LogRecordExporter`.
* `maxExportBatchSize` - the maximum batch size of every export. It must be
smaller or equal to `maxQueueSize`. The default value is `512`.

#### Isolating processor

**Status**: [Development](../document-status.md)

This is an implementation of `LogRecordProcessor` ensuring the log record
passed to `OnEmit` of the configured `processor` does not share mutable data
lmolkova marked this conversation as resolved.
Show resolved Hide resolved
with subsequent registered processors.
For example, the `OnEmit` implementation of the isolating processor can be
a decorator that makes a deep copy of the log record before passing it to
the configured `processor`.

**Configurable parameters:**

* `processor` - processor to be isolated.

## LogRecordExporter

`LogRecordExporter` defines the interface that protocol-specific exporters must
Expand Down
Loading