Monkey-patch structlog to have pickle-able CallsiteParameterAdder #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required for compatibility with TVM PR apache/tvm#16618. Can be removed after upstream `structlog` hynek/structlog#603 lands. This is a backport of the OLLM PR octoml/ollm#409, and is not needed after the MLC-serve migration.
masahi
approved these changes
Mar 11, 2024
Lunderberg
pushed a commit
to Lunderberg/mlc-llm
that referenced
this pull request
Apr 1, 2024
* Isolate model fetching in a separate process * update target detection logic * update metal compilation callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for compatibility with TVM PR apache/tvm#16618. Can be removed after upstream
structloghynek/structlog#603 lands.This is a backport of the OLLM PR https://github.com/octoml/ollm/pull/409, and is not needed after the MLC-serve migration.