Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] Update Mixtral to have well-formed TIR #225

Merged
merged 1 commit into from
Mar 4, 2024
Merged

[Model] Update Mixtral to have well-formed TIR #225

merged 1 commit into from
Mar 4, 2024

Conversation

Lunderberg
Copy link
Member

Inside a T.block, loop variables may not be used, and access to them must be done through the corresponding T.axis.remap output.

@Lunderberg
[Model] Update Mixtral to have well-formed TIR
e653630 
Inside a `T.block`, loop variables may not be used, and access to them
must be done through the corresponding `T.axis.remap` output.
@Lunderberg
Copy link
Member Author

For context, I frequently use tvm.tir.analysis.verify_well_formed(mod) to debug updates to the MLC-LLM optimization pipeline, and this error was caught by that check.

@vinx13 vinx13 merged commit 0f041ef into batch-serving Mar 4, 2024
1 check passed
Lunderberg pushed a commit to Lunderberg/mlc-llm that referenced this pull request Apr 1, 2024
@junrushao
Add auto detect support for vulkan (octoml#225)
eed5a28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinx13 vinx13 vinx13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lunderberg @vinx13