Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin: LLM Summary #4040

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Add plugin: LLM Summary #4040

merged 1 commit into from
Oct 17, 2024

Conversation

larksq
Copy link
Contributor

@larksq larksq commented Aug 13, 2024

I am submitting a new Community Plugin

Repo URL

Link to my plugin: https://github.com/larksq/obsidian-llm-summary

Release Checklist

  • I have tested the plugin on - [ ] Windows - [x] macOS - [ ] Linux - [ ] Android (if applicable) - [ ] iOS (if applicable)

  • My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)

    • main.js
    • manifest.json - [x] styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)

  • The id in my manifest.json matches the id in the community-plugins.json file.

  • My README.md describes the plugin's purpose and provides clear usage instructions.

  • I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.

  • I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.

  • I have added a license in the LICENSE file.

  • My project respects and is compatible with the original license of any code from other plugins that I'm using.

  • I have given proper attribution to these other projects in my README.md.

Please switch to Preview and select one of the following links:

@larksq larksq closed this Aug 13, 2024
@larksq larksq reopened this Aug 13, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest Release is missing the main.js file.
❌ Your latest Release is missing the manifest.json file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Your latest Release is missing the main.js file.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@ObsidianReviewBot
Copy link
Collaborator

Thank you for your submission, an automated scan of your plugin code's revealed the following issues:

Required

[1][2][3]:Remember to rename the sample classes to something that makes sense to your plugin. If there are any errors, Obsidian will spit out this class name, so this will be important for users to debug if they need to.

[1]:The command name should not include the plugin name.

[1]:Please remove anything from the sample plugin that you don't need.


Optional

[1]:We recommend against providing a default hotkey when possible. The reason being that it's easy to pick a hotkey that a user already has configured and they could get confused when that key doesn't do what they expect. Also, it's hard choosing a safe default hotkey that's available for all operating systems.


Do NOT open a new PR for re-validation.
Once you have pushed all of the required changes to your repo, the bot will update the labels on this PR within 6 hours.
If you think some of the required changes are incorrect, please comment with /skip and the reason why you think the results are incorrect.

@ObsidianReviewBot ObsidianReviewBot self-assigned this Aug 14, 2024
@ObsidianReviewBot ObsidianReviewBot added Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made and removed Ready for review labels Aug 14, 2024
@larksq
Copy link
Contributor Author

larksq commented Aug 14, 2024

All changes released.

@ObsidianReviewBot ObsidianReviewBot added Ready for review and removed Changes requested Additional review required PR needs to be reviewed by another person, after the currently requested changes have been made labels Aug 14, 2024
@ObsidianReviewBot ObsidianReviewBot removed their assignment Aug 14, 2024
@ObsidianReviewBot
Copy link
Collaborator

Changes requested by bot have been made, assigning human for additional review.

@joethei
Copy link
Collaborator

joethei commented Sep 2, 2024

pdfs
Use the proper capitalisation.

"fundingUrl": "https://www.qiaosun.me/funding",
This URL returns a 404.
This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.

statusBarItemEl.setText('LLM Ready');, name: 'Initialize Notes Folders',, statusBarItemEl.setText('Defining New Concept..');, statusBarItemEl.setText('LLM Ready');, .setName('New Concept Fields (Required)')
Use sentence case in UI

@joethei joethei added Changes requested Minor changes requested PR can be merged after some final changes have been requested and removed Ready for review labels Sep 2, 2024
@larksq
Copy link
Contributor Author

larksq commented Sep 3, 2024

pdfs Use the proper capitalisation.

"fundingUrl": "https://www.qiaosun.me/funding", This URL returns a 404. This is meant for links to services like Buy me a coffee, GitHub sponsors and so on, if you don't have such a link remove this line.

statusBarItemEl.setText('LLM Ready');, name: 'Initialize Notes Folders',, statusBarItemEl.setText('Defining New Concept..');, statusBarItemEl.setText('LLM Ready');, .setName('New Concept Fields (Required)') Use sentence case in UI

Thank you for your review. All problems have been solved in a later release (v0.1.9). Please check.

@ObsidianReviewBot ObsidianReviewBot added Ready for review Changes made and removed Minor changes requested PR can be merged after some final changes have been requested labels Sep 3, 2024
Copy link

Hello!

I found the following issues in your plugin submission

Errors:

❌ Unable to find a release with the tag 0.1.9. Make sure that the version in your manifest.json file in your repo points to the correct Github Release.


This check was done automatically. Do NOT open a new PR for re-validation. Instead, to trigger this check again, make a change to your PR and wait a few minutes, or close and re-open it.

@larksq
Copy link
Contributor Author

larksq commented Sep 13, 2024

Thanks for pointing out. Fixed by publishing the new release.

Copy link

Hi there, as this PR has not seen any activity in the last 30 days, it will be closed in 15 days unless there are any updates.

@github-actions github-actions bot added the stale label Oct 14, 2024
Link to my plugin: https://github.com/larksq/obsidian-llm-summary

 - [x] I have tested the plugin on
     - [ ] Windows
     - [x] macOS
     - [ ] Linux
     - [ ] Android (if applicable)
     - [ ] iOS (if applicable)

 - [x] My GitHub release contains all required files (as individual files, not just in the source.zip / source.tar.gz)
    - [x] main.js
    - [x] manifest.json - [x] styles.css (optional)
 - [x] GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
 - [x] The id in my manifest.json matches the id in the community-plugins.json file.
 - [x] My README.md describes the plugin's purpose and provides clear usage instructions.
 - [x] I have read the developer policies at https://docs.obsidian.md/Developer+policies, and have assessed my plugins's adherence to these policies.
 - [x] I have read the tips in https://docs.obsidian.md/Plugins/Releasing/Plugin+guidelines and have self-reviewed my plugin to avoid these common pitfalls.
 - [x] I have added a license in the LICENSE file.
 - [x] My project respects and is compatible with the original license of any code from other plugins that I'm using.
 - [x] I have given proper attribution to these other projects in my README.md.
@joethei joethei merged commit 8bc80d0 into obsidianmd:master Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants