Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update all dependencies #943

Closed
wants to merge 2 commits into from
Closed

chore: update all dependencies #943

wants to merge 2 commits into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 7, 2023

Breaking changes are mainly dropping support for Node.js 12 and 14 (which we already stopped supporting),
and API switch from callback to promises.

@targos targos marked this pull request as draft March 7, 2023 15:35
@targos
Copy link
Member Author

targos commented Mar 7, 2023

I can reproduce the failures with v14. Will investigate.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +2.12 🎉

Comparison is base (9975077) 93.20% compared to head (6b03830) 95.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #943      +/-   ##
==========================================
+ Coverage   93.20%   95.33%   +2.12%     
==========================================
  Files          28       28              
  Lines        2149     2143       -6     
==========================================
+ Hits         2003     2043      +40     
+ Misses        146      100      -46     
Impacted Files Coverage Δ
lib/citgm.js 100.00% <100.00%> (+15.78%) ⬆️
lib/grab-project.js 96.03% <100.00%> (+0.03%) ⬆️
lib/package-manager/get-executable.js 100.00% <100.00%> (ø)
lib/package-manager/test.js 99.35% <100.00%> (-0.01%) ⬇️
lib/temp-directory.js 100.00% <100.00%> (+4.25%) ⬆️
lib/unpack.js 95.55% <100.00%> (+0.10%) ⬆️
lib/spawn.js 23.07% <0.00%> (-76.93%) ⬇️
lib/bin/citgm-all.js 94.53% <0.00%> (+5.04%) ⬆️
lib/match-conditions.js 94.00% <0.00%> (+6.00%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@targos targos marked this pull request as ready for review March 8, 2023 07:18
@targos
Copy link
Member Author

targos commented Mar 8, 2023

It was just that stream.promises don't exist in v14.x

@targos
Copy link
Member Author

targos commented Mar 8, 2023

Windows fails everywhere, not sur I'll be able to debug this one.

@targos targos marked this pull request as draft March 8, 2023 07:27
lib/temp-directory.js Outdated Show resolved Hide resolved
@targos
Copy link
Member Author

targos commented Mar 26, 2023

Ironically, the changelog for rimraf@4 has:

Windows performance and reliability improved.

@targos targos marked this pull request as ready for review July 31, 2023 13:28
Breaking changes are mainly dropping support for Node.js 12 and 14
(which we already stopped supporting), and API switch from callback to
promises.
@targos
Copy link
Member Author

targos commented Jul 31, 2023

    # Subtest: tempDirectory.remove: bad path
        1..1
    MESSAGE refusing to remove root directory without preserveRoot:false
        not ok 1 - the message should include the path \\\\.\\NUL
          ---
          at:
            line: 78
            column: 7
            file: file:///D:/a/citgm/citgm/test/test-temp-directory.js
            type: Test
          stack: |
            Test.<anonymous> (file:///test/test-temp-directory.js:78:7)
          ...
        
        # failed 1 test
    not ok 4 - tempDirectory.remove: bad path # time=16.777ms
    
    1..4
    # failed 1 of 4 tests
    # time=57.393ms
not ok 21 - test/test-temp-directory.js # time=57.393ms

@targos targos closed this May 1, 2024
@targos targos deleted the updeps branch May 1, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants