One-Click Postage: Don't use outdated API endpoint #2137
Conversation
Co-Authored-By: April Sylph <[email protected]>
|
Is this currently broken? I use OCP pretty often and I haven't noticed anything |
|
It converts threads to legacy, presumably breaking interoperability with Trim Reblogs. I don't think we want to be doing that. |
|
The number of people who use OCP and the number of people who use Trim
Reblogs, historically, is nowhere near comparable. I don't think we should
regress in features for the possibility that 10% of users somewhere might
be upset that Trim Reblogs might not work.
Regarding what you wrote in discord, I don't think we should be taking
half-joking speculation from two staff members on one potential path for
the SVC migration as gospel. I agree we should move to a NPF endpoint for
this code eventually, but we should do so in alignment with Tumblr's
publicly announced schedule for the deprecation of legacy posts (which will
happen eventually, but has not been thoroughly planned out yet.)
…On Wed, Sep 27, 2023 at 6:53 PM marcustyphoon ***@***.***> wrote:
It converts threads to legacy, presumably breaking interoperability with
Trim Reblogs. I don't think we want to be doing that.
—
Reply to this email directly, view it on GitHub
<#2137 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABZCV66QFQAWF7RHZUGZALX4S36NANCNFSM6AAAAAA5I6HEFU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Are we regressing in features?
I guess I don't understand how these two points mesh together :D If we are going to migrate at some point, why not now? If we aren't going to migrate at all, then sure. It seems to me like I'm viewing the creation of legacy posts as a regression and you're viewing it as a feature; is that accurate? |
One-Click Postage is relatively similar to Quick Reblog in XKit Rewritten, so doing this instead of just breaking it doesn't preserve much functionality (sure, autotagger, multiline captions, yeah, yeah, whatever). I don't see this as as important like I do #2106.
This migrates One-Click Postage to use the modernized backend code that XKit Rewritten's Quick Reblog does instead of the legacy and presumably-someday-removed SVC endpoint when possible (i.e. on React pages).
It removes the share to Twitter/share to Facebook and caption replace options as well as an old option to use a different notification style. Off the top of my head, social media sharing is gone, caption replacing is not a thing post-NPF, and the other notification style didn't work on most pages anyway.