Replace duplicate Pushover Timestamp field with the missing TTL field

[AndyHazz]

Summary

Fixing the duplicate timestamp field, by swapping it for the missing ttl field described in the api documentation: https://pushover.net/api#ttl

Related Linear tickets, Github issues, and Community forum posts

#10984

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

Hey @AndyHazz,

Thanks for the PR, We have created "GHC-326" as the internal reference to get this reviewed.

One of us will be in touch if there are any changes needed, in most cases this is normally within a couple of weeks but it depends on the current workload of the team.

[Joffcom]

@AndyHazz thanks for the PR, there is a tricky bit with this one as it involves a field rename so may break users workflows.

A better option would be to implement a light version 1.1 and show the new option on that that way existing workflows will work as they do now and if you add a new node to the canvas you will be able to use the TTL field.

Let me know what you think or if you have any questions.

[AndyHazz]

The original timestamp will still be there, it's not really being renamed - currently it's duplicated in Pushover.node.ts with an identical name and the same field is shown twice - in the UI no matter which you pick from the dropdown, it adds two fields. Any value you enter, shows in both Timestamp fields.

Removing the duplicate timestamp field shouldn't affect any existing workflows, they can still have a timestamp, it'd just be shown once instead of twice - fixing a bug in the duplicated timestamp field, and adding the missing ttl field.

[AndyHazz]

The untouched timestamp is here:
Line 239