chore: Convert ErrorReporting to a Service to use DI. Add some tests (no-changelog) #11279
+158
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
reviewed
Oct 16, 2024
| import { Service } from 'typedi'; | ||
|
|
||
| @Service() | ||
| export class ErrorReporting { |
There was a problem hiding this comment.
Nit
Suggested change
| export class ErrorReporting { | |
| export class ErrorReporter { |
|
|
||
| import { ErrorReporting } from '../error-reporting'; | ||
|
|
||
| describe('ErrorReporting', () => { |
There was a problem hiding this comment.
Nit
Suggested change
| describe('ErrorReporting', () => { | |
| describe('ErrorReporter', () => { |
| ) {} | ||
|
|
||
| async init() { | ||
| if (this.initialized) return; |
There was a problem hiding this comment.
Should we throw instead? We should prevent multiple init calls from existing.
|
|
||
| initialized = true; | ||
| }; | ||
| beforeSend(event: ErrorEvent, { originalException }: EventHint) { |
There was a problem hiding this comment.
Suggested change
| beforeSend(event: ErrorEvent, { originalException }: EventHint) { | |
| private beforeSend(event: ErrorEvent, { originalException }: EventHint) { |
| export class ErrorReporting { | ||
| private initialized = false; | ||
|
|
||
| private seenErrors = new Set<string>(); |
There was a problem hiding this comment.
Suggested change
| private seenErrors = new Set<string>(); | |
| /** Hashes of error stack traces, to deduplicate error reports. */ | |
| private readonly seenErrors = new Set<string>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAY-2113
Review / Merge checklist