-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(AI Agent Node): Make tools optional when using OpenAI model with Tools agent #11212
base: master
Are you sure you want to change the base?
feat(AI Agent Node): Make tools optional when using OpenAI model with Tools agent #11212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than my comment on the tests - this looks good!
// OpenAI doesn't allow empty tools array so we will provide a more user-friendly error message | ||
if (model.lc_namespace.includes('openai') && tools.length === 0) { | ||
throw new NodeOperationError( | ||
this.getNode(), | ||
"Please connect at least one tool. If you don't need any, try the conversational agent instead", | ||
); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also test this in a test-workflow?
|
Summary
Require Specific Output Format
is toggled for non-tools agentsRelated Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)