New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package configuration file to CPP version. #903

Draft

wnts wants to merge 1 commit into msgpack:cpp_master from wnts:cpp_master

wnts commented Jul 22, 2020

Resolves #901.


          Add package configuration file to CPP version.

6c18342

Resolves msgpack#901.

Author

wnts commented Jul 22, 2020

This still requires some extra work, which I will only perform if there is interest in this PR:

Right now, the exported target contains by default the Boost::system (for boost adaptors and X3 parser support) and zlib dependencies, and they are always searched for by the package config file. Some users don't use these features so they should be optional (I'm thinking about treating them as components in the find_package call).
Set correct MSGPACK_* preprocessor macros on the exported target:

MSGPACK_USE_X3_PARSE: Can be set if this component is requested by user (see 1. above)
MSGPACK_USE_CPP03 : Can be set from information gathered by compiler inspection to determine if C++11 or later is supported (MSGPACK_USE_CPP03)

... Suggestions ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet