Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth): minimal conversion of db/index to ts #17838

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

bbangert
Copy link
Member

Because:

  • We'd like more code to use TypeScript.

This commit:

  • Minimally converts auth-server db/index to TS.

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@bbangert bbangert requested a review from a team as a code owner October 16, 2024 18:23
@dschom dschom self-requested a review October 16, 2024 18:25
Copy link
Contributor

@dschom dschom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dug up the type for most of the any types, cause why not. Take them or leaving depending on how much of a hassle it is. It'd be great to get these in line types defined and reusable at some point.

@bbangert bbangert force-pushed the refactor/auth-db-to-ts branch 2 times, most recently from f0009eb to 28c8bdc Compare October 16, 2024 22:27
@bbangert bbangert force-pushed the refactor/auth-db-to-ts branch 7 times, most recently from 788b256 to 8c2a5a7 Compare October 17, 2024 06:03
packages/fxa-auth-server/lib/db.ts Dismissed Show dismissed Hide dismissed
Because:

* We'd like more code to use TypeScript.

This commit:

* Minimally converts auth-server db/index to TS.
@bbangert bbangert merged commit 6cdeb11 into main Oct 17, 2024
25 checks passed
@bbangert bbangert deleted the refactor/auth-db-to-ts branch October 17, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants