-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(auth): minimal conversion of db/index to ts #17838
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
bbangert
force-pushed
the
refactor/auth-db-to-ts
branch
from
October 16, 2024 19:08
5405327
to
9b1052e
Compare
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
dschom
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dug up the type for most of the any
types, cause why not. Take them or leaving depending on how much of a hassle it is. It'd be great to get these in line types defined and reusable at some point.
dschom
reviewed
Oct 16, 2024
bbangert
force-pushed
the
refactor/auth-db-to-ts
branch
2 times, most recently
from
October 16, 2024 22:27
f0009eb
to
28c8bdc
Compare
dschom
approved these changes
Oct 16, 2024
bbangert
force-pushed
the
refactor/auth-db-to-ts
branch
7 times, most recently
from
October 17, 2024 06:03
788b256
to
8c2a5a7
Compare
bbangert
force-pushed
the
refactor/auth-db-to-ts
branch
from
October 17, 2024 14:58
8c2a5a7
to
81ebe6d
Compare
Because: * We'd like more code to use TypeScript. This commit: * Minimally converts auth-server db/index to TS.
bbangert
force-pushed
the
refactor/auth-db-to-ts
branch
from
October 17, 2024 16:05
81ebe6d
to
13c1fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Checklist
Put an
x
in the boxes that apply