feat(next): paypal createOrder and onApprove hooks #17837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaberindeZA
commented
Oct 16, 2024
| @@ -114,9 +114,11 @@ export class NextJSActionsService { | |||
| async checkoutCartWithPaypal(args: CheckoutCartWithPaypalActionArgs) { | |||
| await new Validator().validateOrReject(args); | |||
|
|
|||
| await this.cartService.checkoutCartWithPaypal( | |||
| await this.cartService.setCartProcessing(args.cartId); | |||
There was a problem hiding this comment.
What about updating the cart to processing here as part of the nextjs-action service?
There was a problem hiding this comment.
I'd like the checkoutCartWithPaypal method to be responsible for these state changes. checkoutCartWithPaypal should throw an error if called on a cart in the processing state.
StaberindeZA
force-pushed
the
fxa-7586-paypal-initial-hooks
branch
2 times, most recently
from
67bd7ca
to
66c3304
Compare
julianpoy
approved these changes
Oct 17, 2024
Because: - Submit PayPal checkout to payments-next This commit: - Add logic to PayPal button createOrder and onApprove hooks. Closes #FXA-7586
StaberindeZA
force-pushed
the
fxa-7586-paypal-initial-hooks
branch
from
66c3304
to
10588e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #FXA-7586
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.