task(auth): Use nest di #17412
task(auth): Use nest di #17412
Conversation
| @@ -16,8 +16,8 @@ export class NotifierService { | |||
| private readonly config: NotifierSnsConfig; | |||
|
|
|||
| constructor( | |||
| configService: ConfigService, | |||
There was a problem hiding this comment.
Is @Inject(...) going to be necessary for everything consumed by Auth? We haven't had to do that over on the Subplat side so far as long as something is marked as @Injectable, is that still the case?
There was a problem hiding this comment.
Yes, I got an error without it which is a little strange, because as you point out it doesn't seem to have been necessary in other projects. I wonder if there's a better solution. I can try removing it, and see if I can get it working without adding injects.
There was a problem hiding this comment.
This is apparently because esbuild does not properly support emitting metadata, so the decorators are only spotted and the information available in some parts:
evanw/esbuild#257
Switching to swc to run this should remedy it. Sigh.
dschom
force-pushed
the
hapi-nest
branch
2 times, most recently
from
95d34cf
to
9910a0b
Compare
Because: - We want to be able to leverage our nest services held in libs This Commit: - Initializes nest DI in hapi - Setups typeDi container with nest services - Switch over to using notfier service from libs - Switch over to using StatsD service from libs
Because
This pull request
Issue that this pull request solves
Closes: # (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.