Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detected shredder sources for tables not in shredder config #6371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BenWu
Copy link
Contributor

@BenWu BenWu commented Oct 18, 2024

Description

Currently reading from the wrong delete source set so all the detected_sources here have the same wrong value

Reviewer, please follow this checklist

@BenWu BenWu requested a review from akkomar October 18, 2024 20:06
@dataops-ci-bot
Copy link

Integration report for "Fix detected shredder sources for tables not in shredder config"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py	2024-10-18 20:04:45.000000000 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/monitoring_derived/shredder_targets_v1/query.py	2024-10-18 20:04:34.000000000 +0000
@@ -281,9 +281,9 @@
                 "table_id": table,
                 "current_sources": [],
                 "detected_sources": [
-                    delete_source_to_dict(detected) for detected in detected_deletions
+                    delete_source_to_dict(detected) for detected in srcs
                 ],
-                "matching_sources": False,
+                "matching_sources": len(srcs) == 0,
             }
         )
 

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants