Skip to content
This repository has been archived by the owner on Oct 4, 2021. It is now read-only.

Allow the startup to complete without taking control of the runloop. #9600

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

iainx
Copy link
Contributor

@iainx iainx commented Jan 24, 2020

Separate the initialization/shutdown sequence into separate methods just on the offchance that a separate runloop might be used. You never know...

@Therzok
Copy link
Contributor

Therzok commented Jan 24, 2020

I don't have enough context to know how to review this.

@@ -761,7 +784,9 @@ public static int Main (string[] args, IdeCustomizer customizer = null)
BrandingService.ApplicationName
), ex);
} finally {
Runtime.Shutdown ();
if (controlMainLoop) {
Copy link
Contributor

@Therzok Therzok Jan 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to refactor this controlMainLoop code? It might end up cleaner if we had 2 separate runloop runners (i.e. in IdeCustomizer), with different implementations and simplify all the signatures that have changed around here?

Separate the initialization/shutdown sequence into separate methods just on the
offchance that a separate runloop might be used.
Base automatically changed from master to main March 9, 2021 14:17
@akoeplinger akoeplinger changed the base branch from main to master March 15, 2021 17:01
Base automatically changed from master to main March 15, 2021 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants