handle invalid std::shared_future reference #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Co-authored-by: Geoffrey Biggs <[email protected]> Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
|
@benmaidel |
benmaidel
force-pushed
the
fix/invalid_shared_future
branch
from
0e13142
to
1ce4564
Compare
I've rebased this on top of #13 and dropped unnecessary commits. |
|
this is finalized in #13 - together with improved output and passing CI 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/orgs/4am-robotics/projects/1/views/15?pane=issue&itemId=22588163
This more a workaround for the underlying bug in actionlib implementation. actionlib should only call the callback function with the shared_future reference if the shared_future is already valid and can be used. This could be a Foxy bug and may be already fixed in newer ros releases. Have to check that.