Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action bridge rebased mojin #13

Merged
merged 19 commits into from
Sep 25, 2023
Merged

action bridge rebased mojin #13

merged 19 commits into from
Sep 25, 2023

Commits on Jul 11, 2023

  1. Update CMakeLists.txt 

    Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @gbiggs @fmessmer
    2 people authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    099e7e1 View commit details
    Browse the repository at this point in the history

  2. Update README.md 

    Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @gbiggs @fmessmer
    2 people authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    553db79 View commit details
    Browse the repository at this point in the history

  3. Update include/ros1_bridge/action_factory.hpp 

    Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @gbiggs @fmessmer
    2 people authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9048f32 View commit details
    Browse the repository at this point in the history

  4. Update resource/get_factory.cpp.em 

    Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @gbiggs @fmessmer
    2 people authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ab8e4d2 View commit details
    Browse the repository at this point in the history

  5. Update ros1_bridge/__init__.py 

    Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @gbiggs @fmessmer
    2 people authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    03e9a13 View commit details
    Browse the repository at this point in the history

  6. Update src/action_bridge.cpp 

    Co-authored-by: Geoffrey Biggs <[email protected]>
Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @gbiggs @fmessmer
    2 people authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    a988cce View commit details
    Browse the repository at this point in the history

  7. risk leaking if the reset call crashes somehow 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    ef4c49e View commit details
    Browse the repository at this point in the history

  8. Change cout to use RCLCPP logging macros. 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    0bcdfd5 View commit details
    Browse the repository at this point in the history

  9. remove commented out code 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    71cea80 View commit details
    Browse the repository at this point in the history

  10. fix parenthesis 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2a4e7b5 View commit details
    Browse the repository at this point in the history

  11. remove unused params 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    2916013 View commit details
    Browse the repository at this point in the history

  12. fix nullptr keyword 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    bf61c29 View commit details
    Browse the repository at this point in the history

  13. remove outdated comments 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9d58aac View commit details
    Browse the repository at this point in the history

  14. pass logger to GoalHandler 

    Signed-off-by: Harsh Deshpande <[email protected]>
    @hsd-dev @fmessmer
    hsd-dev authored and fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    e855ecb View commit details
    Browse the repository at this point in the history

  15. fix code style divergence

    @fmessmer
    fmessmer committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    1b40977 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. more logging via RCLCPP_INFO

    @fmessmer
    fmessmer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d915538 View commit details
    Browse the repository at this point in the history

  2. handle invalid std::shared_future reference

    @benmaidel @fmessmer
    benmaidel authored and fmessmer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    08fc3bc View commit details
    Browse the repository at this point in the history

  3. Use rclcpp logger

    @benmaidel @fmessmer
    benmaidel authored and fmessmer committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f64801a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. fix format

    @fmessmer
    fmessmer committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    8ddb3c2 View commit details
    Browse the repository at this point in the history