Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix interruptGenerate causing the engine to get stuck when using synchronous completion calls #596

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix interruptGenerate causing the engine to get stuck when using synchronous completion calls #596

wants to merge 1 commit into from

Commits on Oct 4, 2024

  1. Reset the interruptSignal after acquiring the lock in completion and … 

    …chatCompletion. It was doing this in effect within asyncGenerate, and kind of in generate, but the completion code would never call generate if interruptGenerate was ever called in the past because it would be stuck true. Also do it in a way that allows users to still call interruptGenerate during a context switch of acquiring the model lock.
    @mitchellw
    mitchellw committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    95071e9 View commit details
    Browse the repository at this point in the history