[Bench] Specialize OpenAI endpoint for backends not supporting debug config #2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasterJH5574
force-pushed
the
10-05-bench-no-debug-config
branch
2 times, most recently
from
2d1bb9a
to
c48aad0
Compare
…config This PR specializes the OpenAI endpoint with the option of "not attaching `debug_config`". Prior to this PR, when `--ignore-eos` is enabled, a `debug_config` field is included in the payload for MLC to recognize. However, some backend servers (e.g., vLLM) do not support this `debug_config` field. So we need to manually specify not attaching this field when benchmarking these backends.
MasterJH5574
force-pushed
the
10-05-bench-no-debug-config
branch
from
c48aad0
to
2e6b145
Compare
tqchen
approved these changes
Oct 5, 2024
MasterJH5574
added a commit
that referenced
this pull request
Oct 5, 2024
…config (#2962) This PR specializes the OpenAI endpoint with the option of "not attaching `debug_config`". Prior to this PR, when `--ignore-eos` is enabled, a `debug_config` field is included in the payload for MLC to recognize. However, some backend servers (e.g., vLLM) do not support this `debug_config` field. So we need to manually specify not attaching this field when benchmarking these backends.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specializes the OpenAI endpoint with the option of "not attaching
debug_config". Prior to this PR, when--ignore-eosis enabled, adebug_configfield is included in the payload for MLC to recognize. However, some backend servers (e.g., vLLM) do not support thisdebug_configfield. So we need to manually specify not attaching this field when benchmarking these backends.