Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RISC-V specific typedefs to riscv.h #253

Open
wants to merge 2 commits into
base: riscv
Choose a base branch
from

Conversation

ideapark
Copy link

No description provided.

Copy link

@echtwerner echtwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why your are moving the typedefs to riscv.h ?

I want to emphasize the importance of leaving comments on PRs. They provide valuable insights and guidance to both contributors and reviewers."

@ideapark
Copy link
Author

ideapark commented Oct 8, 2024

Because the defined type pde_t are specific to riscv architecture,
and there is a defined type pte_t already in riscv.h, and those two
should be close to each other, since they are all riscv virtual memory
related.

Besides, types.h should be used as alias C standard types to compiler
level friendly shorter type names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants