Allow specifying JSON configuration to netremote-server on command-line #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Side Effects
Goals
Technical Details
AccessPointAttributes
fromAccessPointManager
.IAccessPointFactory::Create()
functions into one.AccessPointAttributes
fromIAccessPointCreateArgs
to concreteIAccessPoint
constructor upon creation.string <-> string
property map toAccessPointAttributes
to allow association of unstructured data to access point.NetRemoteServerJsonConfiguration
).netremote-server
CLI flag-c
(--config
, etc.) to specify optional JSON configuration file location.NetRemoteServerConfiguration
with access point attributes parsed from JSON configuration file, if specified.AccessPointDiscoveryAgentOperationsNetlink
to accept function to look up access point attributes, and if available, pass them to theIAccessPointFactory
instance so they are forwarded to the createdIAccessPoint
insteance.Test Results
Reviewer Focus
Future Work
Checklist
all
compiles cleanly.