Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update page.mdx #9478

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update page.mdx #9478

wants to merge 1 commit into from

Conversation

erickirt
Copy link
Contributor

@erickirt erickirt commented Oct 4, 2024

this link leads no where and if spelling is corrected, still leads no where: https://docs.medusajs.com/resources/medusa-container-resources

this link leads no where and if spelling is corrected, still leads no where:
https://docs.medusajs.com/resources/medusa-container-resources
@erickirt erickirt requested a review from a team as a code owner October 4, 2024 15:46
Copy link

changeset-bot bot commented Oct 4, 2024

⚠️ No Changeset found

Latest commit: bd75b9b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 4, 2024

@erickirt is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@erickirt
Copy link
Contributor Author

erickirt commented Oct 4, 2024

Do not merge this, i did not add a fix, just a commented complaint

@damien-thiesson
Copy link
Contributor

Do not merge this, i did not add a fix, just a commented complaint

Hi @erickirt, thank you for your report and contribution. Pull requests are used to fix the source code, rather than just reporting an issue. To report an issue with the documentation without fixing the code yourself, you can click on Report issue in the top right corner of any documentation page. This will create a Github issue that can then be picked up by someone to push an actual PR to fix the link.

Can you close this PR and create an issue instead?

Many thanks :)

Copy link
Contributor

@damien-thiesson damien-thiesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting to close this PR and create an issue instead.

@@ -14,7 +14,7 @@ So, resources in the module, such as services or loaders, can only resolve other

### List of Registered Resources

Find a list of resources or dependencies registered in a module's container in [this Learning Resources reference](!resoures!/medusa-container-resources).
Find a list of resources or dependencies registered in a module's container in [this Learning Resources reference](!resoures!/medusa-container-resources). <_THIS LEADS NO WHERE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, can you please change it to this:

Suggested change
Find a list of resources or dependencies registered in a module's container in [this Learning Resources reference](!resoures!/medusa-container-resources). <_THIS LEADS NO WHERE
Find a list of resources or dependencies registered in a module's container in [this Learning Resources reference](!resources!/medusa-container-resources).

@@ -14,7 +14,7 @@ So, resources in the module, such as services or loaders, can only resolve other

### List of Registered Resources

Find a list of resources or dependencies registered in a module's container in [this Learning Resources reference](!resoures!/medusa-container-resources).
Find a list of resources or dependencies registered in a module's container in [this Learning Resources reference](!resoures!/medusa-container-resources). <_THIS LEADS NO WHERE

---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't remove this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants