feat(notification)!: remove stomper #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First step to full event streaming migration
Somebody forgot to remove function notify.
…moval chore(notification): remove function notify
feat(notification)!: remove trigger
## [4.0.0-beta.1](3.4.8...4.0.0-beta.1) (2024-10-04) ### ⚠ BREAKING CHANGES * **notification:** remove trigger ### Features * **notification:** remove trigger ([bef6af9](bef6af9))
## [4.0.0-beta.2](4.0.0-beta.1...4.0.0-beta.2) (2024-10-06) ### ⚠ BREAKING CHANGES * **roles:** remove stomper * **notification:** grant execute to anonymous ### Features * **notification:** grant execute to anonymous ([070c694](070c694)) * **roles:** remove stomper ([5efe0e7](5efe0e7))
|
Ok, I'm gonna merge this once
|
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stomperdatabase role was used by maevsi/stomper to directly connect to the database and mark notifications for which an email has been sent as acknowledged so that they're not sent more than once by mistake.The new mailer will be part of the main
maevsirepository and will use a POST request to the http api (postgraphile) to mark notifications (at this point those equal to emails) as sent. Therefore access permission for the respective function are set tomaevsi_anonymousas one needs to know the uuid of a notification to mark it as acknowledged which is not meant to be public.