Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tonic): bump tonic-build to 0.12.3 #232

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

BugenZhao
Copy link
Contributor

@BugenZhao BugenZhao commented Oct 10, 2024

In tonic-build version 0.12.3, the compile functions has been renamed to compile_protos, with the original version now marked as deprecated. For simplicity, we may use a version requirement of 0.12.3 and directly remove the deprecated methods.

As a result, the interfaces are not strictly compatible with the upstream. But as long as the application wants to clean up those warnings about deprecation, we'll be compatible.

Signed-off-by: Bugen Zhao <[email protected]>
@BugenZhao BugenZhao changed the title bump tonic-build to 0.12.3 chore(tonic): bump tonic-build to 0.12.3 Oct 10, 2024
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wangrunji0408 wangrunji0408 merged commit 6b01c30 into main Oct 12, 2024
24 checks passed
@wangrunji0408 wangrunji0408 deleted the bz/bump-tonic-build-0-12-3 branch October 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants