-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump tonic version to v0.9 #151
bump tonic version to v0.9 #151
Conversation
I think it's needed. Tonic has breaking API change from 0.8 to 0.9. |
Oh, arrow-flight >= 37 also needs it. That's a larger need. |
Also needed in risingwavelabs/risingwave#10875 for introducing Icelake. |
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
Signed-off-by: Runji Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve myself. :)
@xxchan please review my change
I’m ok. Merge first to unblock work. I might need some more time to think
about it, but we can fix problems later since we are 0.x 🤣
…On Thu, 20 Jul 2023 at 08:32, Runji Wang ***@***.***> wrote:
***@***.**** approved this pull request.
Approve myself. :)
@xxchan <https://github.com/xxchan> PTAL
—
Reply to this email directly, view it on GitHub
<#151 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJBQZNN7SZ4E4P7V4UY3IU3XRDGIBANCNFSM6AAAAAAZYJH5MU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
... I'm wondering whether we need to bump major version #145
changelog: https://github.com/hyperium/tonic/blob/master/CHANGELOG.md
I mainly want this: build:: Support boxing fields