make ENABLE_REFRESH_OAUTH_TOKEN a function

Signed-off-by: Runji Wang <[email protected]>

madsim-rdkafka/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "madsim-rdkafka"
-version = "0.3.4+0.34.0"
+version = "0.4.0+0.34.0"
 edition = "2021"
 authors = ["Runji Wang <[email protected]>"]
 description = "The rdkafka simulator on madsim."

madsim-rdkafka/README.md

@@ -11,7 +11,7 @@ Replace all `rdkafka` entries in your Cargo.toml:
 
 ```toml
 [dependencies]
-rdkafka = { version = "0.3", package = "madsim-rdkafka" }
+rdkafka = { version = "0.4", package = "madsim-rdkafka" }
 ```
 
 ## API Modification
@@ -47,6 +47,8 @@ The following functions are modified to be `async`:
 
 [^1]: wrapped in `tokio::task::spawn_blocking`
 
+The associated constant `ClientContext::ENABLE_REFRESH_OAUTH_TOKEN` is changed to a function in order to make the trait object-safe.
+
 ## DNS Resolution
 
 This crate has cherry-picked [a commit] from Materialize to support rewriting broker addresses.

madsim-rdkafka/src/std/client.rs

@@ -57,7 +57,9 @@ pub trait ClientContext: Send + Sync + 'static {
     ///
     /// This parameter is only relevant when using the `OAUTHBEARER` SASL
     /// mechanism.
-    const ENABLE_REFRESH_OAUTH_TOKEN: bool = false;
+    fn enable_refresh_oauth_token(&self) -> bool {
+        false
+    }
 
     /// Receives log lines from librdkafka.
     ///
@@ -134,7 +136,7 @@ pub trait ClientContext: Send + Sync + 'static {
     ///
     /// Override with an appropriate implementation when using the `OAUTHBEARER`
     /// SASL authentication mechanism. For this method to be called, you must
-    /// also set [`ClientContext::ENABLE_REFRESH_OAUTH_TOKEN`] to true.
+    /// also set [`ClientContext::enable_refresh_oauth_token`] to true.
     ///
     /// The `fmt::Display` implementation of the returned error must not
     /// generate a message with an embedded null character.
@@ -275,7 +277,7 @@ impl<C: ClientContext> Client<C> {
                 >,
             );
         }
-        if C::ENABLE_REFRESH_OAUTH_TOKEN {
+        if context.enable_refresh_oauth_token() {
             unsafe {
                 rdsys::rd_kafka_conf_set_oauthbearer_token_refresh_cb(
                     native_config.ptr(),

madsim-rdkafka/src/std/producer/future_producer.rs

@@ -143,7 +143,9 @@ pub type OwnedDeliveryResult = Result<(i32, i64), (KafkaError, OwnedMessage)>;
 
 // Delegates all the methods calls to the wrapped context.
 impl<C: ClientContext + 'static> ClientContext for FutureProducerContext<C> {
-    const ENABLE_REFRESH_OAUTH_TOKEN: bool = C::ENABLE_REFRESH_OAUTH_TOKEN;
+    fn enable_refresh_oauth_token(&self) -> bool {
+        self.wrapped_context.enable_refresh_oauth_token()
+    }
 
     fn log(&self, level: RDKafkaLogLevel, fac: &str, log_message: &str) {
         self.wrapped_context.log(level, fac, log_message);